feat: img diff when resolution differs #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRSgit
commented
Sep 15, 2022
BREAKING CHANGE: different resolution doesn't fail test immediately - img diff is being done closes #94 Signed-off-by: Jakub Freisler <[email protected]>
Signed-off-by: Jakub Freisler <[email protected]>
FRSgit
force-pushed
the
feat/add-image-diff-when-resolution-differs
branch
from
fd1a399 to
b374189
Compare
github-actions bot
pushed a commit
to braze-inc/cypress-plugin-visual-regression-diff
that referenced
this pull request
Oct 31, 2022
# 1.0.0 (2022-10-31) ### Bug Fixes * btoa utf8 encoding/decoding error ([FRSOURCE#114](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/114)) ([0137014](0137014)) * create missing dirs when renaming screenshot files ([38e5ff5](38e5ff5)) * **deps:** pin dependency vue to 3.2.37 ([FRSOURCE#68](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/68)) ([d09a762](d09a762)) * **deps:** update dependency @frsource/base64 to v1.0.3 ([FRSOURCE#144](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/144)) ([09ecbd8](09ecbd8)) * **deps:** update dependency move-file to v3 ([FRSOURCE#62](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/62)) ([4f6eaf6](4f6eaf6)) * **deps:** update dependency pixelmatch to v5.3.0 ([FRSOURCE#55](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/55)) ([ca5d278](ca5d278)) * **deps:** update dependency sharp to v0.31.1 ([FRSOURCE#132](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/132)) ([15f0f5d](15f0f5d)) * **deps:** update dependency vue to v3.2.38 ([FRSOURCE#101](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/101)) ([e2d3c82](e2d3c82)) * **deps:** update dependency vue to v3.2.39 ([FRSOURCE#110](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/110)) ([8a7f055](8a7f055)) * **deps:** update dependency vue to v3.2.40 ([FRSOURCE#131](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/131)) ([537fd16](537fd16)) * image diff calculation ([529cb22](529cb22)), closes [FRSOURCE#107](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/107) * proper readme info ([dd87e19](dd87e19)) * remove alias leftovers from dist bundles ([407ce79](407ce79)) * remove automated screenshots update ([acb3ef0](acb3ef0)) * reset name cache after tests run ([bfbf138](bfbf138)) * sanitize screenshot filenames ([fc57380](fc57380)) * security vulnerabilities ([d0bda44](d0bda44)) * security vulnerability ([d6f849c](d6f849c)) * text overflowing when image is small ([3b04f8e](3b04f8e)) ### Features * add forceDeviceFactor option ([8d69632](8d69632)) * add matchAgainstPath option ([FRSOURCE#146](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/146)) ([7a5e3a8](7a5e3a8)), closes [FRSOURCE#88](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/88) * add possibility to change images dirname ([b831e94](b831e94)) * add queue flushing in after block ([70f828f](70f828f)) * add title option to matchImage command ([FRSOURCE#81](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/81)) ([4d03866](4d03866)) * add typings ([0a0e8e6](0a0e8e6)) * auto clean unused files ([FRSOURCE#124](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/124)) ([38679a7](38679a7)), closes [FRSOURCE#118](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/118) * don't override screenshots if not needed ([9066017](9066017)) * externalize important APIs ([9f94086](9f94086)) * first implementation ([388cccf](388cccf)) * img diff when resolution differs ([FRSOURCE#108](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/108)) ([c8a5044](c8a5044)), closes [FRSOURCE#94](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/94) * introduce imagesPath option ([FRSOURCE#152](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/152)) ([961e137](961e137)), closes [FRSOURCE#147](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/147) * make library cypress 10 compatible ([b26beb3](b26beb3)) * make plugin Cypress 10 compatible ([a03a17d](a03a17d)) * migrate to @frsource/base64 package ([e4f3a14](e4f3a14)) * provide modern exports ([5c911a1](5c911a1)) * show comparison for successful tests ([FRSOURCE#137](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/137)) ([c09bab3](c09bab3)), closes [FRSOURCE#104](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/104) * show scrollbar for overflowing images ([de994b9](de994b9)) * stop logging all of the tasks ([573e728](573e728)) ### BREAKING CHANGES * deprecate imagesDir option in favor of imagesPath - see docs for additional information * To use autocleanup feature you need to update all of the screenshots, best do it by running your test suite with cypress env 'pluginVisualRegressionUpdateImages' set to true. * matchImage returns object containing comparison details from now on (previously was returning subject element from a chain) * different resolution doesn't fail test immediately - img diff is being done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: different resolution doesn't fail test immediately - img diff is being done
closes #94
Signed-off-by: Jakub Freisler [email protected]