fix: btoa error #114

iamyoki · 2022-09-09T04:06:35Z

closes #113

FRSgit

Hey @iamyoki,
Thanks for your PR ❤️ I have one question regarding the implementation, but I think your approach goes in the good direction, nice job!

FRSgit · 2022-09-10T14:16:16Z

src/commands.ts

-            `${res.message}\n[See comparison](${LINK_PREFIX}${btoa(
-              JSON.stringify({ title, imgPath })
-            )})`
+            `${res.message}\n[See comparison](${LINK_PREFIX}${btoa(unescape(encodeURIComponent(JSON.stringify({


I think we shouldn't use escape/unescape methods as they're described as deprecated.
Is encodeURIComponent not enough to fix this error?

Hi @FRSgit, thanks also for your attention, I'll look into it further soon.

Hi @FRSgit, after research, the best way is to implement an escape Base64 by ourself to replace the deprecated escape, btoa methods, so I found this answer and followed it.
https://stackoverflow.com/a/26603875/15495687

@iamyoki Thanks for doing the research - indeed it seems that this is the best approach. Personally I would think about rereleasing the webtoolkit.base64 on npm (the same way webtoolkit.md5 is released) as it's nicer to be able to share this kind of functionalities with other libraries.
But this solution is well enough for now, so I'd say let's stick with it until somebody will be willing to refactor 😄
Thanks again!

src/Base64.ts

FRSgit

Looks cool now ❤️ Nitpick: I've added direct link to the base64 implementation, so it's easier to be found.
Thanks for the great contribution, merging it right away!

## [1.9.21](v1.9.20...v1.9.21) (2022-09-14) ### Bug Fixes * btoa utf8 encoding/decoding error ([#114](#114)) ([0137014](0137014))

# 1.0.0 (2022-10-31) ### Bug Fixes * btoa utf8 encoding/decoding error ([FRSOURCE#114](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/114)) ([0137014](0137014)) * create missing dirs when renaming screenshot files ([38e5ff5](38e5ff5)) * **deps:** pin dependency vue to 3.2.37 ([FRSOURCE#68](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/68)) ([d09a762](d09a762)) * **deps:** update dependency @frsource/base64 to v1.0.3 ([FRSOURCE#144](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/144)) ([09ecbd8](09ecbd8)) * **deps:** update dependency move-file to v3 ([FRSOURCE#62](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/62)) ([4f6eaf6](4f6eaf6)) * **deps:** update dependency pixelmatch to v5.3.0 ([FRSOURCE#55](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/55)) ([ca5d278](ca5d278)) * **deps:** update dependency sharp to v0.31.1 ([FRSOURCE#132](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/132)) ([15f0f5d](15f0f5d)) * **deps:** update dependency vue to v3.2.38 ([FRSOURCE#101](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/101)) ([e2d3c82](e2d3c82)) * **deps:** update dependency vue to v3.2.39 ([FRSOURCE#110](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/110)) ([8a7f055](8a7f055)) * **deps:** update dependency vue to v3.2.40 ([FRSOURCE#131](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/131)) ([537fd16](537fd16)) * image diff calculation ([529cb22](529cb22)), closes [FRSOURCE#107](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/107) * proper readme info ([dd87e19](dd87e19)) * remove alias leftovers from dist bundles ([407ce79](407ce79)) * remove automated screenshots update ([acb3ef0](acb3ef0)) * reset name cache after tests run ([bfbf138](bfbf138)) * sanitize screenshot filenames ([fc57380](fc57380)) * security vulnerabilities ([d0bda44](d0bda44)) * security vulnerability ([d6f849c](d6f849c)) * text overflowing when image is small ([3b04f8e](3b04f8e)) ### Features * add forceDeviceFactor option ([8d69632](8d69632)) * add matchAgainstPath option ([FRSOURCE#146](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/146)) ([7a5e3a8](7a5e3a8)), closes [FRSOURCE#88](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/88) * add possibility to change images dirname ([b831e94](b831e94)) * add queue flushing in after block ([70f828f](70f828f)) * add title option to matchImage command ([FRSOURCE#81](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/81)) ([4d03866](4d03866)) * add typings ([0a0e8e6](0a0e8e6)) * auto clean unused files ([FRSOURCE#124](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/124)) ([38679a7](38679a7)), closes [FRSOURCE#118](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/118) * don't override screenshots if not needed ([9066017](9066017)) * externalize important APIs ([9f94086](9f94086)) * first implementation ([388cccf](388cccf)) * img diff when resolution differs ([FRSOURCE#108](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/108)) ([c8a5044](c8a5044)), closes [FRSOURCE#94](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/94) * introduce imagesPath option ([FRSOURCE#152](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/152)) ([961e137](961e137)), closes [FRSOURCE#147](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/147) * make library cypress 10 compatible ([b26beb3](b26beb3)) * make plugin Cypress 10 compatible ([a03a17d](a03a17d)) * migrate to @frsource/base64 package ([e4f3a14](e4f3a14)) * provide modern exports ([5c911a1](5c911a1)) * show comparison for successful tests ([FRSOURCE#137](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/137)) ([c09bab3](c09bab3)), closes [FRSOURCE#104](https://github.com/braze-inc/cypress-plugin-visual-regression-diff/issues/104) * show scrollbar for overflowing images ([de994b9](de994b9)) * stop logging all of the tasks ([573e728](573e728)) ### BREAKING CHANGES * deprecate imagesDir option in favor of imagesPath - see docs for additional information * To use autocleanup feature you need to update all of the screenshots, best do it by running your test suite with cypress env 'pluginVisualRegressionUpdateImages' set to true. * matchImage returns object containing comparison details from now on (previously was returning subject element from a chain) * different resolution doesn't fail test immediately - img diff is being done

fix: FRSOURCE#113 btoa error

851cf87

FRSgit requested changes Sep 10, 2022

View reviewed changes

FRSgit assigned FRSgit and iamyoki Sep 10, 2022

FRSgit added the bug Something isn't working label Sep 10, 2022

FRSgit changed the title ~~fix: #113 btoa error~~ fix: btoa error Sep 10, 2022

fix: FRSOURCE#114 implement Base64 utility

e02d1bf

FRSgit reviewed Sep 14, 2022

View reviewed changes

src/Base64.ts Outdated Show resolved Hide resolved

chore: add direct link to base64 implementation

30a84ab

FRSgit approved these changes Sep 14, 2022

View reviewed changes

FRSgit merged commit 0137014 into FRSOURCE:main Sep 14, 2022

github-actions bot pushed a commit that referenced this pull request Sep 14, 2022

chore(release): 1.9.21 [skip ci]

ac3b059

## [1.9.21](v1.9.20...v1.9.21) (2022-09-14) ### Bug Fixes * btoa utf8 encoding/decoding error ([#114](#114)) ([0137014](0137014))

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: btoa error #114

fix: btoa error #114

Uh oh!

iamyoki commented Sep 9, 2022 •

edited by FRSgit

Loading

Uh oh!

FRSgit left a comment

Uh oh!

FRSgit Sep 10, 2022

Uh oh!

iamyoki Sep 12, 2022

Uh oh!

iamyoki Sep 14, 2022 •

edited

Loading

Uh oh!

FRSgit Sep 14, 2022

Uh oh!

Uh oh!

FRSgit left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: btoa error #114

fix: btoa error #114

Uh oh!

Conversation

iamyoki commented Sep 9, 2022 • edited by FRSgit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FRSgit left a comment

Choose a reason for hiding this comment

Uh oh!

FRSgit Sep 10, 2022

Choose a reason for hiding this comment

Uh oh!

iamyoki Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

iamyoki Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FRSgit Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FRSgit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iamyoki commented Sep 9, 2022 •

edited by FRSgit

Loading

iamyoki Sep 14, 2022 •

edited

Loading

FRSgit left a comment •

edited

Loading