Skip to content

feature: allow eslint 8 as a peer dependency #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022
Merged

feature: allow eslint 8 as a peer dependency #145

merged 1 commit into from
Oct 20, 2022

Conversation

philihp
Copy link
Contributor

@philihp philihp commented Aug 23, 2022

Resolves #144

@thymikee
Copy link

thymikee commented Sep 5, 2022

Would be great to have this one warning less 👍🏼 And the plugin works fine with ESLint 8

@philihp
Copy link
Contributor Author

philihp commented Oct 19, 2022

RE #137, this was updated in the boilerplate RN template here facebook/react-native@f3db6cc

@trevorrd
Copy link

Can somebody with write access merge this please? Please and thank you! :)

@trevorrd
Copy link

@philihp --> Do you need to update the package version too? (i.e. 3.2.2?)

@philihp
Copy link
Contributor Author

philihp commented Oct 20, 2022

@philihp --> Do you need to update the package version too? (i.e. 3.2.2?)

Yes, please. I think a minor version bump is probably appropriate.

@gksander gksander merged commit d74acca into FormidableLabs:master Oct 20, 2022
@gksander
Copy link
Contributor

Hi @philihp thanks for contributing this, and apologies for the delay on getting this merged in. I've merged this and released as v3.3.0, which should now be available on NPM 🎈

@trevorrd
Copy link

Hi @philihp thanks for contributing this, and apologies for the delay on getting this merged in. I've merged this and released as v3.3.0, which should now be available on NPM 🎈

@gksander, thank you so much! This is great. Thank you for continuing to support the community! :)

@philihp philihp deleted the philihp-eslint-8 branch October 24, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding eslint 8 as compatible peer dependency
4 participants