Skip to content

chore(breaking): upgrade deps to match eslint 8 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2022
Merged

chore(breaking): upgrade deps to match eslint 8 #250

merged 4 commits into from
Sep 5, 2022

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Sep 5, 2022

Summary

Major bumps:

  • eslint-plugin-flowtype (requires eslint@^8.1, hence peer dep bump as well)
  • eslint-plugin-promise
  • eslint-plugin-react-native
  • eslint-plugin-jest

New deps required as peers by eslint-plugin-flowtype:

  • @babel/plugin-syntax-flow
  • @babel/plugin-transform-react-jsx

Test plan

No warnings related to this plugin. Known issue: FormidableLabs/eslint-plugin-react-native-a11y#145 (will be fixed when merged)

Copy link
Member

@slavikdenis slavikdenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaworek
Copy link
Contributor

jaworek commented Sep 5, 2022

Bueno! Do you want me to test on some specific project?

@thymikee
Copy link
Member Author

thymikee commented Sep 5, 2022

@jaworek I'm gonna release a major version now and it would be great if you could test it :)

@thymikee thymikee merged commit d46ee31 into main Sep 5, 2022
@thymikee thymikee deleted the chore/dep branch September 5, 2022 16:41
@thymikee
Copy link
Member Author

thymikee commented Sep 5, 2022

Not sure why CI didn't kick off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants