addTags on TagHandler #171
Conversation
| * This must be called before any response is sent to the client. | ||
| * Make sure this is called after all addTags calls and only once. | ||
| */ | ||
| public function flushTags() |
There was a problem hiding this comment.
this is for the library only, in the bundle we will have something using Response.
dbu
force-pushed
the
tag-http-response
branch
from
5a8c64a to
3530c26
Compare
dbu
force-pushed
the
tag-http-response
branch
from
3530c26 to
c617cd6
Compare
| The tag handler helps you to invalidate all cache entries that where marked | ||
| with a specified tag. It works only with a ``CacheInvalidator`` that supports | ||
| ``CacheInvalidator::INVALIDATE``. | ||
| .. versionadded:: 1.3 |
There was a problem hiding this comment.
this does not render as nicely as expected, because our sphinx setup does not load basic.css but only theme.css - @ddeboer would you know why we do not load default.css and what i could do to get the
.versionmodified {
font-style: italic;
}
into our css, or load basic.css?
There was a problem hiding this comment.
We use the Read the Docs theme (theme.css) on local builds too, so you can see what it will really look like. Unfortunately, they don’t support the version directives. Pushed a commit that adds some basic formatting for versionadded/versionchanged.
|
i propose we bump the branch-alias to version 1.3 and tag 1.3.0-alpha1 after merging this. then i can work on the bundle and once that is good and we need no further tweaks on TagHandler, we can tag 1.3.0 stable. |
ddeboer
force-pushed
the
tag-http-response
branch
from
8c07293 to
b089678
Compare
|
Merged and... whoops, tagged 1.3.0 stable already. ;) Let’s hope you don't need changes to |
|
cool, thanks! |
follow up of #162
This allows TagHandler to track tags. I tried adding a flush method that calls
header()but feel there is little value to that. See the doc diff for how i propose to use this outside symfony.