Feature/includeable vcl #228
Conversation
Remove the call to flush() after invalidating tags from the tag handler, and add a note to explain why. Fixes FriendsOfSymfony#221.
|
Great work! User context still needs to be done, right? |
| The custom ``X-Cache-Tags`` header should match the tagging header | ||
| :ref:`configured in the cache invalidator <custom_tags_header>`. | ||
| If you want to use different tag from ``X-Cache-Tags`` as defined in fos_ban.vcl, | ||
| the header should match the tagging header :ref:`configured in the cache invalidator <custom_tags_header>`. |
There was a problem hiding this comment.
i think this is a bit confusing. i would say something like:
If you need to use a different tag for the headers than the default ``X-Cache-Tags`` used in ``fos_ban.vcl``,
you need to write your own VCL code and change the tagging header :ref:`configured in the cache invalidator <custom_tags_header>`.
|
thanks a lot! i think we maybe want to add an introductionary section explaining the concept of the includable vcl and the options to use absolute paths or symlink or copy the files. and that you can copy the file and edit if you need customization, at the cost of no longer automatically updating. |
|
we can still do the user context later and already merge this i think, when the details have been sorted out here. |
…cs-for-taghandler-flush Update Documentation
…ache into feature/includeable-vcl
|
Hi David's I also fixed a small docblock error |
|
👍 I agree with the resources directory. Can you please squash commits? |
|
Resubmitted in #229 |
|
Just a tip: for a PR, you can squash (rebase) commits and force push them to the PR branch, so you won't have to open a separate PR. 😉 |
Split of the vcl's from the tests into the /config directory ready to be included in the varnish configuration.
These vcl files are still included in the unit tests and as such are part of the tests