Get rid of build failures with symfony 2.7 #180
Conversation
dbu
force-pushed
the
ignore-deprecations
branch
2 times, most recently
from
9b5c0ae to
08e799b
Compare
| @@ -35,6 +35,8 @@ matrix: | |||
|
|
|||
| before_script: | |||
| - sh -c 'if [ "$SYMFONY_VERSION" != "" ]; then composer require --dev --no-update symfony/symfony=$SYMFONY_VERSION; fi;' | |||
| # E_ALL & ~E_DEPRECATED is 24575 | |||
| - sh -c 'FLAWED_DEPRECATIONS=`echo "$SYMFONY_VERSION >= 2.7"|bc`; if [ $FLAWED_DEPRECATIONS = 1 ]; then echo "error_reporting = 24575" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini; fi;' | |||
There was a problem hiding this comment.
man, bash is a horrible thing!
|
Why doesn’t just echoing |
dbu
force-pushed
the
ignore-deprecations
branch
3 times, most recently
from
2b8d7f3 to
bd4306d
Compare
|
hm, that should work. i was thinking too complicated. |
dbu
force-pushed
the
ignore-deprecations
branch
2 times, most recently
from
a1937cb to
19c5fbf
Compare
| before_script: | ||
| - sh -c 'if [ "$SYMFONY_VERSION" != "" ]; then composer require --dev --no-update symfony/symfony=$SYMFONY_VERSION; fi;' | ||
| - sh -c 'echo "$SYMFONY_VERSION >= 2.7"|bc' | ||
| - sh -c 'FLAWED_DEPRECATIONS=`echo "$SYMFONY_VERSION >= 2.7"|bc`; echo $FLAWED_DEPRECATIONS' | ||
| - sh -c 'FLAWED_DEPRECATIONS=`echo "$SYMFONY_VERSION >= 2.7"|bc`; if [ "$FLAWED_DEPRECATIONS" = "1" ]; then echo "error_reporting = E_ALL & ~E_DEPRECATED" >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini; fi;' |
There was a problem hiding this comment.
still struggling with figuring out why travis behaves differently than my local system
dbu
force-pushed
the
ignore-deprecations
branch
2 times, most recently
from
ba89f6c to
ac83baa
Compare
|
LOL, this is getting worse and worse. 😉 Try this: if [ $(echo "$SYMFONY_VERSION >= 2.7" | bc) -eq 1 ]; then echo …; fiAnd yeah, Bash is horrible. |
dbu
force-pushed
the
ignore-deprecations
branch
from
ac83baa to
e91cc23
Compare
|
good idea. the other problem is that |
|
Blegh, yeah, my solution doesn't work with |
dbu
force-pushed
the
ignore-deprecations
branch
from
e91cc23 to
6a57021
Compare
|
hm, now i finally manage to have "error_reporting = E_ALL & ~E_DEPRECATED" in the php.ini file, but phpunit still fails :-( damn, what to do? |
dbu
force-pushed
the
ignore-deprecations
branch
4 times, most recently
from
b330a64 to
3329114
Compare
|
okay, so apart from debug code that fails with hhvm, this now builds. unfortunately, despite all the things i throw everywhere, the build still spits out tons of deprecated warnings on the console: https://travis-ci.org/FriendsOfSymfony/FOSHttpCacheBundle/jobs/43100069 shall i remove the debug code from .travis.yml and then we just merge? |
|
@dbu for any such case, please open issues in Symfony. deprecation messages should be triggered only when you call deprecated methods, not when Symfony provides a BC layer that you don't call. I know that several broken PRs have been merged during the hackday last weekend. I haven't reviewed all of them yet, so issues will help me. |
|
created symfony/symfony#12868 |
dbu
force-pushed
the
ignore-deprecations
branch
2 times, most recently
from
e6eb2eb to
382fd87
Compare
…reak the build if we treat deprecated as an error
dbu
force-pushed
the
ignore-deprecations
branch
from
382fd87 to
f227d42
Compare
Get rid of build failures with symfony 2.7
Symfony 2.7 calls its own deprecated methods, raising warnings that break the build if we treat deprecated as an error...
Fix #176