Skip to content

Fix Travis buid #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2015
Merged

Fix Travis buid #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"symfony/framework-bundle": "~2.3"
},
"require-dev": {
"friendsofsymfony/http-cache": "~1.2@dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't put the same requirement in both require and require-dev (Composer warns about it). Put the dev flag directly in require (it will only affect the requirement when being in the root package anyway)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yes, but we don't want people to get the unstable version of the library when installing a tagged version of the bundle. Do we then need to keep the minimum-stability?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dev in requirements is root-only. It is ignored in dependencies. Only the root package can control stability restrictions

"mockery/mockery": "0.9.*",
"monolog/monolog": "*",
"sensio/framework-extra-bundle": "~2.3",
Expand All @@ -45,7 +46,6 @@
"FOS\\HttpCacheBundle\\": ""
}
},
"minimum-stability": "dev",
"extra": {
"branch-alias": {
"dev-master": "1.2.x-dev"
Expand Down