Produce code coverage only once #215
Conversation
This should fix variations in code coverage due to hhvm finishing before any of the PHP builds. It should also make the tests run faster on Travis.
ddeboer
force-pushed
the
produce-coverage-once
branch
from
54cccf3 to
d076fab
Compare
| - php: 5.6 | ||
| env: | ||
| - PHPUNIT_FLAGS="--coverage-clover=coverage.clover" | ||
| - COVERAGE=true | ||
|
|
||
| # only needed for the hackaround for https://github.com/symfony/symfony/issues/12868 |
There was a problem hiding this comment.
afaik there is now an official method for this: http://symfony.com/blog/new-in-symfony-2-7-phpunit-bridge
do you want to try that as well? so we could clean up some of the tricks we did to avoid problems with the deprecation notices.
@wouterj i thought we are using this in the cmf now, but can't find the right place to point out. can you help us find the example?
There was a problem hiding this comment.
@dbu just require symfony/phpunit-bridge and your ready. Then, fix all deprecations. After this, you're probably left with a few deprecations because:
- Legacy classes are used to remain BC
- Things can't be fixed nicely (the usage of
factory-serviceinservices.xmlfor instance)
For (1), you have to annotate your tests/testcases with @group legacy and for (2), you use the env variable SYMFONY_DEPRECATION_HELPER=weak.
There was a problem hiding this comment.
thanks a lot wouter! will try this in a separate PR then.
|
👍 |
This fixes the variations in code coverage we saw previously, due to hhvm finishing before any of the PHP builds.