remove hacks to avoid failure due to deprecations #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, Scrutinizer now fails because of my #215. The problem is that there’s no way to influence the order of builds on Travis (as far as I’m aware), so when the code coverage build ends up last, we’re way over Scrutinizer’s timeout. I suggest we just raise that timeout to 10 mins. or so. |
dbu
force-pushed
the
remove-deprecation-hacks
branch
from
2517c23 to
03869a9
Compare
|
can you change scrutinizer timeout in the configuration panel? |
|
You can try to set it in this PR: external_code_coverage:
timeout: 600 # Timeout in seconds. |
ddeboer
added a commit
that referenced
this pull request
Jun 5, 2015
remove hacks to avoid failure due to deprecations
|
Thanks! Nice to get rid of the hacks. I’ll tweak code coverage in a separate PR. |
ddeboer
added a commit
to FriendsOfSymfony/FOSHttpCache
that referenced
this pull request
Jun 10, 2015
ddeboer
added a commit
that referenced
this pull request
Jun 10, 2015
This was referenced Jun 10, 2015
ddeboer
added a commit
that referenced
this pull request
Jun 10, 2015
|
Actually, I think jobs are started in the order they are listed in the travis config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.