Skip to content

Correct path for the warmup call #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Correct path for the warmup call #3414

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00e7377
Correct path for the warmup call
oittaa Apr 16, 2020
f73c402
Merge branch 'master' into patch-1
Apr 23, 2020
e9e909b
Merge branch 'master' into patch-1
Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/standard_python37/warmup/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ def test_warmup():
main.app.testing = True
client = main.app.test_client()

r = client.get('/')
r = client.get('/_ah/warmup')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewers: this is the warmup route in main.py

python-docs-samples/appengine/standard_python37/warmup/main.py

Lines 27 to 30 in 00e7377

@app.route('/_ah/warmup')
def warmup():
# Handle your warmup logic here, e.g. set up a database connection pool
return '', 200, {}

assert r.status_code == 200