Skip to content

Sdk update 20230324 171523 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 96 commits into from
Mar 24, 2023
Merged

Sdk update 20230324 171523 #8

merged 96 commits into from
Mar 24, 2023

Conversation

jaksart1
Copy link
Contributor

PR summary

Added support for specific secret data types while updating and creating secrets, that are specific to each indivicual secret format.

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

semantic-release-bot and others added 26 commits December 9, 2022 08:07
* added secret create example

* list
* fix(model): pulled in latest v2 endpoint updates

* fix(tests): fixed imports of v2 integration tests
* added oneOf and examples

* added int test

* updated examples and added types to secret update data

* added more secret tests

* import fix

* fixed import

* udpated test

* udpated test

* update to secret tests
BREAKING CHANGE: Secret data structs are no long string maps, they are oneOf types with sepcific properties based on the type of secret being created/updated
# [3.0.0](https://github.ibm.com/coligo/go-sdk/compare/v2.0.5...v3.0.0) (2023-03-24)

### Features

* **oneOf:** oneOf added for v3 release ([#30](https://github.ibm.com/coligo/go-sdk/issues/30)) ([4f0d815](https://github.ibm.com/coligo/go-sdk/commit/4f0d8151e978e9f0cb22cb05a99481300129a81f))

### BREAKING CHANGES

* **oneOf:** Secret data structs are no long string maps, they are oneOf types with sepcific properties based on the type of secret being created/updated
* fix(generator): SDK update 20230324-173258

* fix(deps): updated dependencies

* fix(deps): currency update
Signed-off-by: John Sartore <[email protected]>
@jaksart1 jaksart1 requested a review from reggeenr March 24, 2023 21:25
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - LGTM

@jaksart1 jaksart1 merged commit 743a707 into main Mar 24, 2023
@jaksart1 jaksart1 deleted the sdk-update-20230324-171523 branch March 24, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants