Revert old SSL/TLS logic change #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My only concern is if this will work with the IBM JDK rather than the Oracle JDK. You could pull a docker image with the IBM JDK and try to execute this there. |
|
Looks like it was fixed in https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-370 |
germanattanasio
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, a change was made to the Java SDK core to try and fix some
SSLHandshakeExceptions showing up in Visual Recognition on Oracle JDK 7. The PR to try and make that fix is here: watson-developer-cloud/java-sdk#890However, there was an issue reported later that this "fix" introduced some other potential problems. Here is that issue: watson-developer-cloud/java-sdk#1020
I went back to investigate by using the old logic and Oracle JDK 7 with Visual Recognition and I didn't run into any problems. Based on the timing of the original occurrence, my guess is it had something to do with the transition to IAM authentication and the new endpoint and was just temporary. Either way, if the original logic works and avoids the potential problems that were reported, I think that's preferred.