-
Notifications
You must be signed in to change notification settings - Fork 18
Feat/auth methods #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
190b48a
to
2b913e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is coming together! A few questions here. We prob can get rid of some constructors in the base service. What do you think about moving adding headers to the connectors in the form of WithAuthentication
methods?
f0da1d0
to
dd30d6d
Compare
do not authenticate in WS connector as we are setting auth headers in Authenticate()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good - just a few minor changes. Approving now though.
316776c
to
9d8e7ef
Compare
This pull request updates authentication to use Authenticators rather than AuthConfigs. Additionally, legacy authentication logic was removed. Changes to the core essentially followed changes to the dotnet sdk core and I have tried to make a bunch of new changes to Connectors to make sure we match
dotnet
as closely as possile. I have tested changes with IAM forRestConnector
, will do some more testing on other authenticators, and forWSConnector
.We are using branch 1.0.0-rc to stage major release changes. Below is the new snippet for authentication:
Following changes to respective service files will be made:
Constructors:
In methods: