Skip to content

feat(setServiceUrl): use setServiceUrl instead of setServiceEndpoint #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2019

Conversation

mamoonraja
Copy link
Member

BREAKING CHANGE: Use SetServiceUrl to set the service endpoint rather than SetEndpoint

BREAKING CHANGE: Use SetServiceUrl to set the service endpoint rather than SetEndpoint
Copy link
Member

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good! tagged phil on review as well

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the service_url value is used, we'll need to validate it and possibly throw/raise an error if it's not valid. And we should add tests that check this as well :)

@mediumTaj
Copy link
Member

For Unity we didn't have a testing platform until very recently. We were only able to do integration tests. We're moving to the new way of testing as part of the unit test generation epic. Even now though we cannot test Unity in CI since we are being blocked from downloading/installing the Unity application in travis. Also no way of finding code coverage...yet :)

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment which might or might not lead to additional changes, but I'll let you decide :)

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things that you can choose to address or not. Looks good.

@padamstx
Copy link
Member

Just realized that we need a GetServiceUrl() method on the BaseService class :)

@padamstx padamstx self-requested a review September 12, 2019 18:54
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but just realized we need a GetServiceUrl() method on BaseService :)

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mamoonraja mamoonraja merged commit 684b901 into 1.0.0-rc2 Sep 12, 2019
@christiancompton christiancompton deleted the feat/serServiceUrl branch February 10, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants