-
Notifications
You must be signed in to change notification settings - Fork 18
feat(setServiceUrl): use setServiceUrl instead of setServiceEndpoint #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: Use SetServiceUrl to set the service endpoint rather than SetEndpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good! tagged phil on review as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the service_url value is used, we'll need to validate it and possibly throw/raise an error if it's not valid. And we should add tests that check this as well :)
For Unity we didn't have a testing platform until very recently. We were only able to do integration tests. We're moving to the new way of testing as part of the unit test generation epic. Even now though we cannot test Unity in CI since we are being blocked from downloading/installing the Unity application in travis. Also no way of finding code coverage...yet :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment which might or might not lead to additional changes, but I'll let you decide :)
b6f1d40
to
1efae53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things that you can choose to address or not. Looks good.
1efae53
to
88b47b8
Compare
Just realized that we need a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but just realized we need a GetServiceUrl() method on BaseService :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
BREAKING CHANGE: Use SetServiceUrl to set the service endpoint rather than SetEndpoint