Skip to content

feat(setServiceUrl): use setServiceUrl instead of setServiceEndpoint #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 12, 2019
Merged

feat(setServiceUrl): use setServiceUrl instead of setServiceEndpoint #16

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c33bf8
feat(setServiceUrl): use setServiceUrl instead of setServiceEndpoint
mamoonraja Sep 10, 2019
9665758
refactor: valdiate url before making a request
mamoonraja Sep 11, 2019
78584a2
refactor(authentication): authenticate inside connectors
mamoonraja Sep 11, 2019
4f468e6
feat(Authentication): make auth type case insesitive
mamoonraja Sep 11, 2019
88b47b8
refactor: add check for url
mamoonraja Sep 12, 2019
c4587af
refactor: provide getServiceUrl method and refactor connectors
mamoonraja Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions BaseService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace IBM.Cloud.SDK
public class BaseService
{
protected Authenticator authenticator;
protected string url;
protected string serviceUrl;
public string ServiceId { get; set; }
protected Dictionary<string, string> customRequestHeaders = new Dictionary<string, string>();
public static string PropNameServiceUrl = "URL";
Expand All @@ -46,7 +46,7 @@ public BaseService(Authenticator authenticator, string serviceId) {
props.TryGetValue(PropNameServiceUrl, out string url);
if (!string.IsNullOrEmpty(url))
{
SetEndpoint(url);
SetServiceUrl(url);
}
}

Expand All @@ -62,9 +62,9 @@ protected void SetAuthentication(RESTConnector connector)
}
}

public void SetEndpoint(string endpoint)
public void SetServiceUrl(string url)
{
url = endpoint;
serviceUrl = url;
}

/// <summary>
Expand Down