Skip to content

Treatment of order="A" changed #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

order="A" interpretation is always done based on src1, src2 continuity flags, no matter what type
promotion steps must be made.

This should also address some Coverity "likely copy/paste" issues.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

order="A" interpretation is always done based on src1, src2 flags,
no matter what type promotion steps must be made.

This should also address some Coverity "likely copy/paste" issues.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.129% (+0.06%) from 91.065%
when pulling f146db2 on improve-order-processing-in-elementwise-common
into 89266a7 on master.

Copy link

github-actions bot commented Feb 5, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Feb 5, 2024

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_71 ran successfully.
Passed: 908
Failed: 1
Skipped: 86

@oleksandr-pavlyk oleksandr-pavlyk merged commit 542def4 into master Feb 6, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the improve-order-processing-in-elementwise-common branch February 6, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants