Skip to content

Fix coverity issue in linalg and clip dispatchers #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix coverity issue in linalg and clip dispatchers #1535

merged 2 commits into from
Feb 7, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR makes changes similar to those make in _elementwise_common.py file in gh-1526 to resolve Coverity reported issue.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Coverity report fix for _linear_agebra_functions
1531a63 
Made changes similar to those made in _elementwise_common.py file,
where processing of order="A" keyword is done based on flags of
both src1 and src2 irrespective of type promotion steps necessary.
@oleksandr-pavlyk
Coverity report fix for _clip
1db33c6 
Made changes similar to those made in _elementwise_common.py file,
where processing of order="A" keyword is done based on flags of
all arguments irrespective of type promotion steps necessary.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.138% (-0.007%) from 91.145%
when pulling 1db33c6 on fix-coverity-issue-in-linalg-dispatcher
into 71b1640 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_95 ran successfully.
Passed: 908
Failed: 1
Skipped: 86

ndgrigorian
ndgrigorian approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage change is trivial: the line count went down but the same branches are covered.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4e95dc3 into master Feb 7, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-coverity-issue-in-linalg-dispatcher branch February 7, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian