Skip to content

Expanded intel_device_info output #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Added "free_memory" for Free Global Memory on the device in bytes, "memory_clock_rate" for Maximum Memory Clock Rate in MHz, and "memory_bus_width" for bus width in bits.

Additions come from https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Added "free_memory" for Free Global Memory on the device in bytes,
"memory_clock_rate" for Maximum Memory Clock Rate in MHz, and
"memory_bus_width" for bus width in bits.
Copy link

github-actions bot commented Apr 26, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Apr 26, 2024

Coverage Status

coverage: 88.136% (-0.08%) from 88.218%
when pulling 94e3661 on add-free-memory-intel-descriptor
into aaf444e on master.

Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_312 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

Fixed typo

Co-authored-by: ndgrigorian <[email protected]>
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_313 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we verified this worked on PVC with ZES_ENABLE_SYSMAN=1, it may be a good idea to document that this must be set to get the ext_intel_free_memory descriptor.

The lenient verbiage is to allow Level-Zero driver to change
its defaults.
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_315 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

@oleksandr-pavlyk oleksandr-pavlyk merged commit 5a93ea0 into master Apr 29, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-free-memory-intel-descriptor branch April 29, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants