-
Notifications
You must be signed in to change notification settings - Fork 30
Implement take_along_axis function per Python Array API #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_205 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_208 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_209 ran successfully. |
9ad0338
to
eaf2585
Compare
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_235 ran successfully. |
The function is planned for Python Array API 2024.12 specification.
eaf2585
to
c139d2c
Compare
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_237 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_239 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_240 ran successfully. |
9629b43
to
0e69998
Compare
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_245 ran successfully. |
1 similar comment
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_245 ran successfully. |
Array API standard conformance tests for dpctl=0.18.0dev0=py310ha798474_246 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a PR to reuse the new dpctl function in dpnp-1969. The existing and new dpnp tests are passed with that dpctl PR locally.
@oleksandr-pavlyk One thing that I did realize, though: would it make sense to add |
Yes, makes total sense. Let's do it in a separate PR though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the branch out and it works, this LGTM.
Thank you @oleksandr-pavlyk !
The function is planned for Python Array API 2024.12 specification.