Skip to content

Leverage on dpctl.tensor implementation in dpnp.take_along_axis #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 5, 2024

The PR proposes to leverage on dpctl.tensor implementation in dpnp.take_along_axis function.
Additionally, the function signature is extended with new keyword mode to provide a control how out-of-bounds indices will be handled.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 5, 2024
@antonwolfy antonwolfy force-pushed the dpctl-take_along_axis branch from 59ce748 to 6002c73 Compare August 5, 2024 12:31
Copy link
Contributor

github-actions bot commented Aug 5, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review August 7, 2024 10:29
@vlad-perevezentsev vlad-perevezentsev self-requested a review August 12, 2024 10:46
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 5fda819 into master Aug 12, 2024
34 of 45 checks passed
@antonwolfy antonwolfy deleted the dpctl-take_along_axis branch August 12, 2024 13:38
github-actions bot added a commit that referenced this pull request Aug 12, 2024
)

* Implement dpnp.take_along_axis through dpctl.tensor

* Added more tests to cover new logic

* Increase test coverage

* Fix type in docstring of dpnp.put() 5fda819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants