-
Notifications
You must be signed in to change notification settings - Fork 22
Leverage on dpctl.tensor implementation in dpnp.take_along_axis
#1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59ce748
to
6002c73
Compare
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
6 tasks
vlad-perevezentsev
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Aug 12, 2024
) * Implement dpnp.take_along_axis through dpctl.tensor * Added more tests to cover new logic * Increase test coverage * Fix type in docstring of dpnp.put() 5fda819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to leverage on dpctl.tensor implementation in
dpnp.take_along_axis
function.Additionally, the function signature is extended with new keyword
mode
to provide a control how out-of-bounds indices will be handled.