-
Notifications
You must be signed in to change notification settings - Fork 30
Feature/code style automation #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/code style automation #414
Conversation
c279935
to
b0e74b5
Compare
a844986
to
8e7ab15
Compare
It is imperative that source code passes all the linter checks before this effort is merged. My attempt to take this for a ride revealed black auto-formats some code that flake8 flags, example of it being __all__ = (a
+ b
+ c
+ d ) Flake8 runs on Cython files, and flags legal Cython extensions of Python as syntactic errors. |
The black docs point out to this possibility and provide a flake config option. I have added the exception to the |
7da077b
to
dc5a48a
Compare
@diptorupd I know that muting warnings fixes CI. I would prefer the following way: run checks locally. Find most danger warnings. Fix in separate PRs and the apply this PR. |
It will split CI changes from fixes and code improvements. |
6237235
to
4066b6b
Compare
b85c0a6
to
57802ca
Compare
- black now is set ot 80 char max line width - isort configs that play well with black
57802ca
to
d3a107f
Compare
Various changes to code style tooling:
flake8
,isort
jobs added to check for Python code style for new PRs againstmaster
,gold/2021
,release
branches.black
max line width changed to 80 chars.flake8
andisort
configs added.pre-commit
hooks added to make it possible to run all these checks prior to pushing code.CONTRIBUTION.md
updated.