Skip to content

Fix/code style #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix/code style #416

wants to merge 6 commits into from

Conversation

diptorupd
Copy link
Contributor

@oleksandr-pavlyk I fixed most of the issues in our Cython files found using flake and applied isort and black. One issue I ran into was that the order of imports in __init__.py matters. With the sorted imports in the file the tests fail to execute. For this reason, I reverted the changes isort made to __init__.py.

@diptorupd diptorupd mentioned this pull request Apr 30, 2021
Closed
@diptorupd
Copy link
Contributor Author

diptorupd commented Apr 30, 2021 •
edited
Loading

@oleksandr-pavlyk I fixed almost all the flake8 issues. Some of the issues need to be ignored as these are not applicable to Cython. I have rebased this PR on top of #412, so you can see the last few pending issues in the CI.

@diptorupd diptorupd closed this Apr 30, 2021
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Apr 30, 2021
Merged
@diptorupd diptorupd deleted the fix/code_style branch May 1, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diptorupd @oleksandr-pavlyk