Skip to content

Extend pre-commit checks #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Extend pre-commit checks #1183

wants to merge 1 commit into from

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 13, 2022 •
edited
Loading

The list of following checks is implemented:

  1. from https://github.com/pre-commit/pre-commit-hooks:
  • check-case-conflict
  • check-toml
  • end-of-file-fixer
  • fix-byte-order-marker
  • trailing-whitespace
  1. from https://github.com/pre-commit/pygrep-hooks:
  • python-check-blanket-type-ignore
  • python-check-mock-methods
  • python-no-eval
  • python-no-log-warn
  • python-use-type-annotations
  • rst-backticks
  • rst-directive-colons
  • rst-inline-touching-normal
  1. black
  2. isort
  3. flake8
  4. clang-format

All reported issues were either resolved or suppressed, depending on severity and frequency in the code.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy
Update pre-commit version to 3.0.0
880d14a 
Add end-of-file-fixer and trailing-whitespace

Add black

Apply black formatter

Follow a recommendation to specify the language for black

Add isort

Fix language config for black

Use python 3.9

Switch back to recommended flow for black

Apply isort

Add flake8

Remove extra space at the end of .flake8

Resolve E issues of flake8

Resolve flake8 issues

Resolve flake8 issues in docstrings and docstrings

Add clang-format
@antonwolfy
Copy link
Contributor Author

Done by #1448, #1449, #1450, #1451, #1453, #1454.

@antonwolfy antonwolfy closed this Jul 13, 2023
@antonwolfy antonwolfy deleted the extend_pre_commit branch July 13, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antonwolfy