Skip to content

Added isort to pre-commit config #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2023
Merged

Added isort to pre-commit config #1451

merged 2 commits into from
Jun 22, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 22, 2023 •
edited
Loading

The PR proposes to extend pre-commit configuration with isort tool.

Note, dpnp/__init__.py is excluded from the scope due to circular import issue otherwise.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jun 22, 2023
vlad-perevezentsev
vlad-perevezentsev approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 3f202cf into master Jun 22, 2023
@antonwolfy antonwolfy deleted the add_isort branch June 22, 2023 12:30
@antonwolfy antonwolfy mentioned this pull request Jul 13, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev