Remove MKL_VERSION_2024 variable from cmake files #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
Jun 21, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 27, 2024
* Get rid of MKL_VERSION_2024 variable * Return back a quite discovery acb74b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneMKL 2024.0 is a minimum required version in
meta.yamlas both build and run dependency.This PR is an attempt to clean up the code and to remove a temporary solution implemented in #1567 for proper MKL discovery during the build process. As for now we should not consider a building with
OneMKL < 2024.0 version.