Make it build with ghc-9.12 #1968
Conversation
|
This needs to be rebased on #1965 |
Still a draft, still a WIP 😀 |
erikd
force-pushed
the
erikd/ghc-9.12
branch
4 times, most recently
from
fae19b0 to
364bf1c
Compare
erikd
force-pushed
the
erikd/ghc-9.12
branch
4 times, most recently
from
2d95ac5 to
d9c2257
Compare
No longer needed. GHC has been deriving this typeclass for some time and ghc-9.12 now warns about it being redundant.
Needed to update the `cardano-node` dependency from `10.1.3` to `10.3` and use all the Cardano dependencies specified by `node`.
erikd
force-pushed
the
erikd/ghc-9.12
branch
2 times, most recently
from
0d21bfd to
9533601
Compare
erikd
force-pushed
the
erikd/ghc-9.12
branch
2 times, most recently
from
0dbfb39 to
a8aaf52
Compare
erikd
force-pushed
the
erikd/ghc-9.12
branch
2 times, most recently
from
687b460 to
fc4231b
Compare
Co-Authored-By: Marcin Szamotulski <[email protected]> Co-Authored-By: Javier Sagredo <[email protected]> Co-Authored-By: Hamish Mackenzie <[email protected]>
And remove redundant `allow-newer` stanzas.
* Fix `packages.ekg` issue. * Make `extra-packages: cardano-cli` nix only * Disable broken haddock
| type: git | ||
| location: https://github.com/IntersectMBO/cardano-node | ||
| tag: 36871ba0cd3e86a5dbcfd6878cdb7168bb4e56a1 | ||
| --sha256: sha256-v0q8qHdI6LKc8mP43QZt3UGdTNDQXE0aF6QapvZsTvU= |
There was a problem hiding this comment.
I think it's safer to restore the node srp.
DBSync needs to build with a compatible set of CHaP dependencies. The safest way is to use the same index-state as a released target node version. Since the release of node to CHaP is later than its index state date, an srp is neceassary.
There was a problem hiding this comment.
To take the node from CHaP with a given index-state is just a safe. Part of this PR is adding a constraint
. , cardano-node ^>= 10.3
which together with the index-state locks the node down pretty hard to an exact version.
There was a problem hiding this comment.
I was mostly worried about all other CHaP dependencies not the node. However, I think we can defer this until the next release.
| , hackage.haskell.org 2024-10-10T00:52:24Z | ||
| , cardano-haskell-packages 2024-11-26T16:00:26Z | ||
| , hackage.haskell.org 2025-05-23T06:30:40Z | ||
| , cardano-haskell-packages 2025-05-16T20:03:45Z |
There was a problem hiding this comment.
Curious how was this index state chosen? Does it follow a node version?
There was a problem hiding this comment.
I do not see why it has to follow the node right down to the git hash. Does the latest node form CHaP that follows the constraint and the CHaP index state not suffice? We could even extend the constraint so its something like
, cardano-node == 10.3.1
That effectively locks it to a release which corresponds to a specific git hash.
Description
Make it build with ghc-9.12.
Not yet complete.
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.