-
Notifications
You must be signed in to change notification settings - Fork 162
Make it build with ghc-9.12 #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
69b95f7
0f4ad6f
4c58501
3e590a3
75bc06d
d50a296
9270d9b
ac69e73
57c04c1
a88d16b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,8 @@ repository cardano-haskell-packages | |
d4a35cd3121aa00d18544bb0ac01c3e1691d618f462c46129271bccf39f7e8ee | ||
|
||
index-state: | ||
, hackage.haskell.org 2024-10-10T00:52:24Z | ||
, cardano-haskell-packages 2024-11-26T16:00:26Z | ||
, hackage.haskell.org 2025-05-23T06:30:40Z | ||
, cardano-haskell-packages 2025-05-16T20:03:45Z | ||
|
||
packages: | ||
cardano-db | ||
|
@@ -67,34 +67,35 @@ package snap-server | |
-- only if the `cardano-node` is compiled with `+rtview`. | ||
flags: -openssl | ||
|
||
allow-newer: | ||
, swagger2:aeson | ||
-- The version of ouroboros-consensus specified by cardano-node uses an earlier version of | ||
-- quickcheck-state-machine that does not compile with ghc-9.10 so we allow a never version | ||
-- that builds with ghc-9.10 (and earlier). | ||
, ouroboros-consensus:quickcheck-state-machine | ||
-- --------------------------------------------------------- | ||
|
||
constraints: | ||
-- STM 2.5.2 is broken: https://github.com/haskell/stm/issues/76 | ||
, stm >= 2.5.3.1 | ||
-- Earlier versions do not compile with ghc-9.10. | ||
, quickcheck-state-machine ^>= 0.10 | ||
-- esqueleto >= 3.6 has API chamges | ||
, esqueleto ^>= 3.5.11.2 | ||
|
||
-- --------------------------------------------------------- | ||
-- New version of `text` exposes a `show` function and in the `node` | ||
-- code,`Data.Text` is being imported unqualified (bad idea IMO) which | ||
-- then clashes with the `show` in `Prelude`. | ||
, text < 2.1.2 | ||
|
||
, cardano-node ^>= 10.3 | ||
|
||
if impl (ghc >= 9.12) | ||
allow-newer: | ||
-- https://github.com/kapralVV/Unique/issues/11 | ||
, Unique:hashable | ||
|
||
-- https://github.com/Gabriella439/Haskell-Pipes-Safe-Library/pull/70 | ||
, pipes-safe:base | ||
|
||
-- https://github.com/haskellari/postgresql-simple/issues/152 | ||
, postgresql-simple:base | ||
, postgresql-simple:template-haskell | ||
|
||
-- https://github.com/haskell-hvr/int-cast/issues/10 | ||
, int-cast:base | ||
|
||
-- The two following one-liners will cut off / restore the remainder of this file (for nix-shell users): | ||
-- when using the "cabal" wrapper script provided by nix-shell. | ||
-- --------------------------- 8< -------------------------- | ||
-- Please do not put any `source-repository-package` clause above this line. | ||
|
||
source-repository-package | ||
type: git | ||
location: https://github.com/IntersectMBO/cardano-node | ||
tag: 36871ba0cd3e86a5dbcfd6878cdb7168bb4e56a1 | ||
--sha256: sha256-v0q8qHdI6LKc8mP43QZt3UGdTNDQXE0aF6QapvZsTvU= | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's safer to restore the node srp. DBSync needs to build with a compatible set of CHaP dependencies. The safest way is to use the same index-state as a released target node version. Since the release of node to CHaP is later than its index state date, an srp is neceassary. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To take the node from CHaP with a given
which together with the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was mostly worried about all other CHaP dependencies not the node. However, I think we can defer this until the next release. |
||
subdir: | ||
cardano-node | ||
cardano-submit-api | ||
trace-dispatcher | ||
trace-forward | ||
trace-resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious how was this index state chosen? Does it follow a node version?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see why it has to follow the
node
right down to the git hash. Does the latestnode
form CHaP that follows the constraint and theCHaP
index state not suffice? We could even extend the constraint so its something likeThat effectively locks it to a release which corresponds to a specific git hash.