Skip to content

FTPlan times StridedArray #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 3, 2022

Fixes #178. Now, the following works:

julia> v = rand(ComplexF64, 10);

julia> f = plan_leg2cheb(v);

julia> f * view(v, :) == f * v
true

I've conservatively required the arrays to be contiguous, as judged from their sizes and strides.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #179 (add1ee8) into master (8a82d79) will decrease coverage by 0.00%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   78.79%   78.79%   -0.01%     
==========================================
  Files          13       13              
  Lines        2108     2117       +9     
==========================================
+ Hits         1661     1668       +7     
- Misses        447      449       +2     
Impacted Files Coverage Δ
src/libfasttransforms.jl 77.94% <86.66%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a82d79...add1ee8. Read the comment docs.

MikaelSlevinsky added a commit that referenced this pull request Aug 3, 2022
MikaelSlevinsky added a commit that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should multiplication of FTPlan take StridedArrays as arguments instead of Arrays?
2 participants