Test against downstream packages #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 91.91% 91.78% -0.13%
==========================================
Files 16 16
Lines 1459 1461 +2
==========================================
Hits 1341 1341
- Misses 118 120 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Test failure in Expression: last(axes(b, 1)) ≡ RealInfinity()
Evaluated: ℵ₀ ≡ +∞Perhaps it's an issue with the test, and it should check for an integer instead? |
|
Yes the test should change. This change was needed to support |
|
Would it be ok to make me a member of this repo? I would like to get these tests working to catch downstream breakages earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.