Fix contiguous_axis #412
Fix contiguous_axis #412
Conversation
| ArrayInterfaceCore = "0.1.5" | ||
| ArrayInterfaceOffsetArrays = "0.1.2" |
There was a problem hiding this comment.
Why drop the 0.1.2 requirement?
There was a problem hiding this comment.
Because the most recent changes fix the issues caused by the forwarding trait
There was a problem hiding this comment.
This was a lower bound.
Because of:
JuliaArrays/ArrayInterface.jl#272
I cannot easily double check what actually changed in that version.
I'd be more comfortable leaving the lower bound of 0.1.2.
If you explicitly tested that 0.1.0 and 0.1.1 do work, then that's okay.
There was a problem hiding this comment.
Oh I didn't explicitly test the lower versions. I was just trying to get everything working with master going forward
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 84.61% 84.60% -0.01%
==========================================
Files 38 38
Lines 9559 9562 +3
==========================================
+ Hits 8088 8090 +2
- Misses 1471 1472 +1
Continue to review full report at Codecov.
|
Locally, this gets everything working with the current master branch of ArrayInterface