Skip to content

Fix contiguous_axis #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Fix contiguous_axis #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8488e9
Fix contiguous_axis
Tokazama Jun 9, 2022
b3359e4
Update Project.toml
Tokazama Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"
VectorizationBase = "3d5dd08c-fd9d-11e8-17fa-ed2836048c2f"

[compat]
ArrayInterface = "6.0.1 - 6.0.11"
ArrayInterface = "6"
ArrayInterfaceCore = "0.1.5"
ArrayInterfaceOffsetArrays = "0.1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop the 0.1.2 requirement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the most recent changes fix the issues caused by the forwarding trait

Copy link
Member

@chriselrod chriselrod Jun 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a lower bound.
Because of:
JuliaArrays/ArrayInterface.jl#272
I cannot easily double check what actually changed in that version.

I'd be more comfortable leaving the lower bound of 0.1.2.
If you explicitly tested that 0.1.0 and 0.1.1 do work, then that's okay.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't explicitly test the lower versions. I was just trying to get everything working with master going forward

ArrayInterfaceOffsetArrays = "0.1"
ArrayInterfaceStaticArrays = "0.1.2"
CPUSummary = "0.1.3 - 0.1.8, 0.1.11"
ChainRulesCore = "1"
Expand Down
3 changes: 3 additions & 0 deletions src/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ end
end
Expr(:block, Expr(:meta, :inline), staticexpr(Cnew))
end
function ArrayInterface.contiguous_axis(::Type{LowDimArrayForBroadcast{D,T,N,A}}) where {D,T,N,A}
ArrayInterface.contiguous_axis(A)
end
@inline function ArrayInterface.stride_rank(
::Type{LowDimArrayForBroadcast{D,T,N,A}},
) where {D,T,N,A}
Expand Down