Skip to content

Upgrade base image to m91 #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Upgrade base image to m91 #1142

merged 3 commits into from
Apr 5, 2022

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Mar 28, 2022

@@ -155,7 +155,7 @@ RUN pip install pycuda && \

RUN pip install pysal && \
pip install seaborn python-dateutil dask python-igraph && \
pip install pyyaml joblib husl geopy ml_metrics mne pyshp && \
pip install pyyaml joblib husl geopy mne pyshp && \
Copy link
Contributor Author

@rosbo rosbo Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping ml_metrics. This is an old package created by Ben Hamner. Last updated in 2015. Fails to install at build time now:

#17 58.62 Collecting ml_metrics
#17 58.64   Downloading ml_metrics-0.1.4.tar.gz (5.0 kB)
#17 58.65   Preparing metadata (setup.py): started
#17 59.04   Preparing metadata (setup.py): finished with status 'error'
#17 59.05   error: subprocess-exited-with-error
#17 59.05   
#17 59.05   × python setup.py egg_info did not run successfully.
#17 59.05   │ exit code: 1
#17 59.05   ╰─> [1 lines of output]
#17 59.05       error in ml_metrics setup command: use_2to3 is invalid.
#17 59.05       [end of output]
#17 59.05   
#17 59.05   note: This error originates from a subprocess, and is likely not a problem with pip.
#17 59.05 error: metadata-generation-failed
#17 59.05 
#17 59.05 × Encountered error while generating package metadata.
#17 59.05 ╰─> See above for output.

Also, it was already failing at import time.

In our Python image currently released:

import ml_metrics

Fails with:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
/tmp/ipykernel_34/1657033094.py in <module>
----> 1 import ml_metrics

/opt/conda/lib/python3.7/site-packages/ml_metrics/__init__.py in <module>
----> 1 from quadratic_weighted_kappa import *
      2 from elementwise import *
      3 from auc import auc
      4 from average_precision import apk, mapk

ModuleNotFoundError: No module named 'quadratic_weighted_kappa'

@rosbo rosbo requested a review from Philmod April 5, 2022 17:53
Copy link
Contributor

@Philmod Philmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if build successful.

@rosbo rosbo merged commit f069226 into main Apr 5, 2022
@rosbo rosbo deleted the upgrade-m91 branch April 5, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants