Inliner optimization fixups #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After llvm#94815, this is only used within ModuleToPostOrderCGSCCPassAdaptor::run(), so keep it local to that function. (cherry picked from commit b312cbf)
The passed SCC is the current SCC we're working on. (cherry picked from commit 0555afd)
Rather than doing delta counting of the total number of functions, just increment it when we see a new function. (cherry picked from commit 81f4fb6)
As opposed to using Node::isDead(), which is no longer accurate after This is only used in diagnostics. (cherry picked from commit ebdb6f4)
With llvm#94815, the nodes belonging to dead functions are no longer invalidated, but kept around to batch delete at the end of the call graph walk. The ML inliner needs to be updated to handle this. This fixes some asserts getting hit, e.g. https://crbug.com/348376263. (cherry picked from commit 94471e6)
The RefSCC that a function marked dead is in may still contain valid SCCs that we want to visit. We rely on InvalidatedSCCs to skip SCCs containing dead functions. The addition of RefSCCs in CallGraphUpdater to InvalidatedRefSCCs was causing asserts as reported in llvm#94815. Fix some more CallGraphUpdater function deletion methods as well. (cherry picked from commit 8d800e6)
SvyatoslavScherbina
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of KT-69697 Native: LLVM inliner optimization might have brought new bugs
Cherry-picked fixups mentioned in llvm#94815