Fix problems in Qt5.11 generator #128
Conversation
The fix for Qt5.12 breaks pythonqt_generator for 5.11. Patch includes better checking for precompiled headers and errors out early rather than failing when linking the src/ with mysterious missing symbols. Signed-off-by: John Bowler <[email protected]>
|
Florian Link's last check-in to generator/qtscript_masterinclude.h breaks pythonqt_generator on earlier versions than Qt5.12 (it introduces a duplicate definition because the #define results in declarations of the same functions in two places.) Tested against Qt5.11.11 using header files generatored from Qt5.11.3, Qt5.12.12 and Qt5.13.2 (Qt5.14.2 generation fails for the same reason as Qt5.11.11 does; the Qt6 coompat changes.) Also makes the build stop if the precompiled headers aren't found rather than wading through the complication then failing at the link step. |
generated_cpp_512 was never added; do you know why? Qt5.15.11 compiles and passes the tests with these headers so I could do a pull request with that and even with generated_cpp_513 but there's no point if there is some known problem with those generated files. Adding tests for the generator requires the official Qt header files for the release. Perfectly possible with a pre-built dedicated test machine but you seem to be building the system (in a docker or similar) each time so that's pretty tricky given that Qt changes the downloads regularly. |
I guess it wasn't needed by anybody? Maybe @usiems knows the answer. Generally, I think it would be nice if the sources could just be generated in a build step for the currently used version by the user, but at the moment it probably would make sense to add the generated sources at least for 5.12 and 5.15 (as soon as that works reliably). |
The generator didn't work for the 5.12 sources, and I didn't invest the time to find and fix the problem, assuming that the differences between 5.11 and 5.12 wouldn't be that great. The same happened when we switched MeVisLab to Qt 5.15, where the old 5.11 wrappers still are "good enough" for our purposes. Too much other stuff with higher priority. |
- a previous fix for Qt5.12 breaks pythonqt_generator for 5.11 - includes better checking for precompiled headers and errors out early rather than failing when linking the src/ with mysterious missing symbols.
- a previous fix for Qt5.12 breaks pythonqt_generator for 5.11 - includes better checking for precompiled headers and errors out early rather than failing when linking the src/ with mysterious missing symbols.
- a previous fix for Qt5.12 breaks pythonqt_generator for 5.11 - includes better checking for precompiled headers and errors out early rather than failing when linking the src/ with mysterious missing symbols.
- a previous fix for Qt5.12 breaks pythonqt_generator for 5.11 - includes better checking for precompiled headers and errors out early rather than failing when linking the src/ with mysterious missing symbols.
- a previous fix for Qt5.12 breaks pythonqt_generator for 5.11 - includes better checking for precompiled headers and errors out early rather than failing when linking the src/ with mysterious missing symbols.
The fix for Qt5.12 breaks pythonqt_generator for 5.11. Patch includes better checking for precompiled headers and errors out early rather than failing when linking the src/ with mysterious missing symbols.