Retab #129
Merged
Retab #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand all the tabs in non-binary source files. Signed-off-by: John Bowler <[email protected]>
|
The change for build/common.prf is in pull request #128 |
mrbean-bremen
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Thanks. There remain inconsistencies in the formatting, but these have been there in the first place (as can be seen in the original code), so I'll merge this is as.
| @@ -1203,7 +1203,7 @@ bool AbstractMetaClass::hasVirtualDestructor() const | |||
| static bool functions_contains(const AbstractMetaFunctionList &l, const AbstractMetaFunction *func) | |||
| { | |||
| foreach (const AbstractMetaFunction *f, l) { | |||
| if ((f->compareTo(func) & AbstractMetaFunction::PrettySimilar) == AbstractMetaFunction::PrettySimilar) | |||
| if ((f->compareTo(func) & AbstractMetaFunction::PrettySimilar) == AbstractMetaFunction::PrettySimilar) | |||
There was a problem hiding this comment.
Looks like here a tab should be 4 spaces - not that there is any consistent formatting here...
mrbean-bremen
pushed a commit
to mrbean-bremen/pythonqt
that referenced
this pull request
Oct 29, 2023
Expand all the tabs in non-binary source files
mrbean-bremen
pushed a commit
that referenced
this pull request
Oct 29, 2023
Expand all the tabs in non-binary source files
mrbean-bremen
pushed a commit
that referenced
this pull request
Nov 1, 2023
Expand all the tabs in non-binary source files
mrbean-bremen
pushed a commit
that referenced
this pull request
Nov 2, 2023
Expand all the tabs in non-binary source files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand all the tabs in non-binary source files.