Update the ABI to support Floating-Point Exceptions. #5164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st officially supported CPU with FP exceptions. While the original rule was a good intention, it was at odds with the Arm ABI, which is also adopted by Linux and macOS, making code harder to port. It was also at odds with the Arm Architecture in the sense that if offers a direct way to convey to software when FP exceptions are supported and when they are enabled, and this rule was negating such contract.
|
@pmsjt : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit ea29a83: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@TylerMSFT I'll merge this PR based on your approval. If this article requires further changes, please open a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the ABI to be in concordance, with the introduction of the first officially supported CPU with FP exceptions.
While the original rule was a good intention, it was at odds with the Arm ABI, which is also adopted by Linux and macOS, making code harder to port.
It was also at odds with the Arm Architecture in the sense that if offers a direct way to convey to software when FP exceptions are supported and when they are enabled, and this rule was negating such contract.