Skip to content

Update installation.md #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JungYeolYang
Copy link

No description provided.

@PRMerger18
Copy link
Contributor

@JungYeolYang : Thanks for your contribution! The author, @conceptdev, has been notified to review your proposed change.

@Jak-MS
Copy link
Contributor

Jak-MS commented Apr 16, 2019

@SunnyDeng - this seems to be a submitted Korean translation of the article. Can you review?

Thanks.

@SunnyDeng
Copy link

@JasonCard can you please check the loc scope?

@JasonCard
Copy link
Contributor

@SunnyDeng I found that this file is currently in localization. HB maybe delayed due to large amount of updates. Will follow up with loc vendor on ETA.

@conceptdev
Copy link
Contributor

Note that this PR is against the English repo - it cannot be merged here. As Jason said, the page translation is in progress and will appear here https://docs.microsoft.com/ko-kr/visualstudio/mac/installation

@nschonni
Copy link
Contributor

Looks like there is a problem with the deployment since the edit button on https://docs.microsoft.com/ko-kr/visualstudio/mac/installation points to this repo instead of the file in https://github.com/MicrosoftDocs/visualstudio-docs.ko-kr

@conceptdev
Copy link
Contributor

Thanks @nschonni I didn't notice that... seems like different behavior to what I've seen before; the loc team is on this thread so we'll figure it out!

@SunnyDeng
Copy link

@nschonni if there is no loc file existing in loc repo, then OPS will fall back the article to English version on DOCS, then the Edit is re-directed to the article in EN repo.
For this article, seems EN article was published long time ago, but the loc version doesn't exist in the loc repo. Various reasons may caused this result. I'd like to wait for @JasonCard to confirm after he checkes the loc pipeline and schedule.
Thank you for your patience!

@JasonCard
Copy link
Contributor

@SunnyDeng Loc vendor found this file was put on hold via mistake, so they are following up on it, and we should know ETA tomorrow. In any case, should we ask Moravia Feedback team to move this PR to Korean repo?

@SunnyDeng
Copy link

@JasonCard thanks for checking! This one is a PR can't be transfer to ko-kr as an issue unless manually transfer. Let's prioritze this article release as much as we can. In the meanwhile, could you please pass the contributor translation to our production team as a loc reference?

@SunnyDeng
Copy link

@Jak-MS please close the PR here.

@JasonCard
Copy link
Contributor

@SunnyDeng Yes, will do.

@ktoliver ktoliver closed this Apr 18, 2019
@JasonCard
Copy link
Contributor

Hi @JungYeolYang,
Thank you for your contribution.
This article is now localized and published live:
https://docs.microsoft.com/ko-kr/visualstudio/mac/installation?view=vsmac-2019

Kind regards,
Microsoft DOCS International Team
cc @SunnyDeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants