[TASK] Drop getLineNo() from the Renderable interface
#1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
The concept of being able to get rendered is logically independent from having a position in the input stream. Hence, both concepts should not be intermingled in the `Renderable` interface. (We might want to add a dedicated interface for classes that are linked to specific points in the input stream later, though.)
oliverklee
force-pushed
the
task/drop-lineno-from-renderable
branch
from
1da74d1 to
46b15d2
Compare
JakeQZ
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
No deprecation notice required, since classes implementing the original interface will still have the method. (And PHP is not strict about whether a method is defined in the parameter type expected, as long as it exists in the actual class of object provided.)
I changed this in the commit message to "conflated", which is possibly more accurate, though "intermingled" was fine. |
Thanks - always glad to work with a native speaker! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of being able to get rendered is logically independent from having a position in the input stream.
Hence, both concepts should not be intermingled in the
Renderableinterface.(We might want to add a dedicated interface for classes that are linked to specific points in the input stream later, though.)