[CLEANUP] Avoid Hungarian notation in OutputFormat (part 1)
#1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
JakeQZ
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
I made some suggestions for clearer names for the Boolean properties (to clarify that they are Booleans). However, this would mean that they are no longer consistent with the getters and setters. And given that these don't correspond to any formal CSS data type, I don't think it's worth the effort renaming them - unlike in the case of Size.number.
| @@ -18,7 +18,7 @@ class OutputFormat | |||
| * | |||
| * @var bool | |||
| */ | |||
| private $bRGBHashNotation = true; | |||
| private $rgbHashNotation = true; | |||
There was a problem hiding this comment.
Suggested change
| private $rgbHashNotation = true; | |
| private $useRgbHashNotation = true; |
| @@ -27,7 +27,7 @@ class OutputFormat | |||
| * | |||
| * @var bool | |||
| */ | |||
| private $bSemicolonAfterLastRule = true; | |||
| private $semicolonAfterLastRule = true; | |||
There was a problem hiding this comment.
Suggested change
| private $semicolonAfterLastRule = true; | |
| private $renderSemicolonAfterLastRule = true; |
oliverklee
added a commit
that referenced
this pull request
Mar 6, 2025
As suggested in #1098. The setters are not changed a those are part of the public API.
JakeQZ
pushed a commit
that referenced
this pull request
Mar 6, 2025
As suggested in #1098. The setters are not changed as those are part of the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #756