Skip to content

[CLEANUP] Avoid Hungarian notation in OutputFormat (part 1) #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[CLEANUP] Avoid Hungarian notation in OutputFormat (part 1) #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/OutputFormat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class OutputFormat
*
* @var bool
*/
private $bRGBHashNotation = true;
private $rgbHashNotation = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private $rgbHashNotation = true;
private $useRgbHashNotation = true;


/**
* Declaration format
Expand All @@ -27,7 +27,7 @@ class OutputFormat
*
* @var bool
*/
private $bSemicolonAfterLastRule = true;
private $semicolonAfterLastRule = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private $semicolonAfterLastRule = true;
private $renderSemicolonAfterLastRule = true;


/**
* Spacing
Expand All @@ -38,7 +38,7 @@ class OutputFormat
*
* @var string
*/
private $sSpaceAfterRuleName = ' ';
private $spaceAfterRuleName = ' ';

/**
* @var string
Expand Down Expand Up @@ -274,15 +274,15 @@ public function setStringQuotingType(string $quotingType): self
*/
public function getRGBHashNotation(): bool
{
return $this->bRGBHashNotation;
return $this->rgbHashNotation;
}

/**
* @return $this fluent interface
*/
public function setRGBHashNotation(bool $rgbHashNotation): self
{
$this->bRGBHashNotation = $rgbHashNotation;
$this->rgbHashNotation = $rgbHashNotation;

return $this;
}
Expand All @@ -292,15 +292,15 @@ public function setRGBHashNotation(bool $rgbHashNotation): self
*/
public function getSemicolonAfterLastRule(): bool
{
return $this->bSemicolonAfterLastRule;
return $this->semicolonAfterLastRule;
}

/**
* @return $this fluent interface
*/
public function setSemicolonAfterLastRule(bool $semicolonAfterLastRule): self
{
$this->bSemicolonAfterLastRule = $semicolonAfterLastRule;
$this->semicolonAfterLastRule = $semicolonAfterLastRule;

return $this;
}
Expand All @@ -310,15 +310,15 @@ public function setSemicolonAfterLastRule(bool $semicolonAfterLastRule): self
*/
public function getSpaceAfterRuleName(): string
{
return $this->sSpaceAfterRuleName;
return $this->spaceAfterRuleName;
}

/**
* @return $this fluent interface
*/
public function setSpaceAfterRuleName(string $whitespace): self
{
$this->sSpaceAfterRuleName = $whitespace;
$this->spaceAfterRuleName = $whitespace;

return $this;
}
Expand Down