Skip to content

[CLEANUP] Avoid Hungarian notation in Document #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

[CLEANUP] Avoid Hungarian notation in Document #929

merged 1 commit into from
Feb 16, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #756

@oliverklee oliverklee self-assigned this Feb 15, 2025
@coveralls
Copy link

coveralls commented Feb 15, 2025 •
edited
Loading

Coverage Status

coverage: 50.498%. remained the same
when pulling 7aab8c4 on cleanup/hungarian-document
into e1fa3b6 on main.

@oliverklee oliverklee force-pushed the cleanup/hungarian-document branch from b5b3492 to 7aab8c4 Compare February 15, 2025 12:21
JakeQZ
JakeQZ approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was ready for review and you just forgot to request one. Looks fine.

@JakeQZ JakeQZ merged commit 8f8fe75 into main Feb 16, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian-document branch February 16, 2025 02:07
@oliverklee
Copy link
Collaborator Author

I assume this was ready for review and you just forgot to request one.

Indeed it was, and indeed I did. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ