Skip to content

[CLEANUP] Avoid Hungarian notation in Document #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/CSSList/Document.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,24 +71,24 @@ public function getAllRuleSets(): array
* @param CSSList|RuleSet|string $element
* the `CSSList` or `RuleSet` to start the search from (defaults to the whole document).
* If a string is given, it is used as rule name filter.
* @param bool $bSearchInFunctionArguments whether to also return Value objects used as Function arguments.
* @param bool $searchInFunctionArguments whether to also return Value objects used as Function arguments.
*
* @return array<int, Value>
*
* @see RuleSet->getRules()
*/
public function getAllValues($element = null, $bSearchInFunctionArguments = false): array
public function getAllValues($element = null, $searchInFunctionArguments = false): array
{
$sSearchString = null;
$searchString = null;
if ($element === null) {
$element = $this;
} elseif (\is_string($element)) {
$sSearchString = $element;
$searchString = $element;
$element = $this;
}
/** @var array<int, Value> $result */
$result = [];
$this->allValues($element, $result, $sSearchString, $bSearchInFunctionArguments);
$this->allValues($element, $result, $searchString, $searchInFunctionArguments);
return $result;
}

Expand All @@ -98,18 +98,18 @@ public function getAllValues($element = null, $bSearchInFunctionArguments = fals
* Note that this does not yield the full `DeclarationBlock` that the selector belongs to
* (and, currently, there is no way to get to that).
*
* @param string|null $sSpecificitySearch
* @param string|null $specificitySearch
* An optional filter by specificity.
* May contain a comparison operator and a number or just a number (defaults to "==").
*
* @return array<int, Selector>
* @example `getSelectorsBySpecificity('>= 100')`
*/
public function getSelectorsBySpecificity($sSpecificitySearch = null): array
public function getSelectorsBySpecificity($specificitySearch = null): array
{
/** @var array<int, Selector> $result */
$result = [];
$this->allSelectors($result, $sSpecificitySearch);
$this->allSelectors($result, $specificitySearch);
return $result;
}

Expand Down