[TASK] Add Tests for Document::getAllDeclarationBlocks()
#956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added
the
testing
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
tests/get-all-declaration-blocks
branch
from
1a44e9b to
a1accfb
Compare
JakeQZ
reviewed
Feb 20, 2025
There was a problem hiding this comment.
The tests look fine. But I find them difficult to follow because I can't immediately see how $this->subject has been setUp(). Would it perhaps be clearer for the subject to be set up on a per-test basis? And maybe a separate pre-PR to remove the setUp() method, which I don't think is warranted.
oliverklee
force-pushed
the
tests/get-all-declaration-blocks
branch
from
a1accfb to
245d68a
Compare
|
Done: #963 |
oliverklee
force-pushed
the
tests/get-all-declaration-blocks
branch
from
245d68a to
e822151
Compare
|
Updated an repushed. |
JakeQZ
requested changes
Feb 20, 2025
oliverklee
force-pushed
the
tests/get-all-declaration-blocks
branch
from
9651087 to
7fac016
Compare
JakeQZ
requested changes
Feb 20, 2025
Also remove a misleading and incorrect comment. Part of #757
oliverklee
force-pushed
the
tests/get-all-declaration-blocks
branch
from
7fac016 to
997eaf7
Compare
Indeed. My bad. Done. |
JakeQZ
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove a misleading and incorrect comment.
Part of #757