Skip to content

[TASK] Extend and streamline KeyFrameTest #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[TASK] Extend and streamline KeyFrameTest #971

merged 1 commit into from
Feb 20, 2025

Conversation

oliverklee
Copy link
Collaborator

Part of #757

@oliverklee
[TASK] Extend and streamline KeyFrameTest
f03fa14 
- use a per-test subject similar to #963
- add a missing `@covers` annotation for the parent class
- add tests for the line number

Part of #757
@oliverklee oliverklee requested a review from JakeQZ February 20, 2025 20:27
@oliverklee oliverklee self-assigned this Feb 20, 2025
@coveralls
Copy link

Coverage Status

coverage: 53.778%. remained the same
when pulling f03fa14 on task/avoid-shared-subject-keyframe
into 981464c on main.

JakeQZ
JakeQZ approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename getLineNo() to getLineNumber() at some point...

@JakeQZ JakeQZ merged commit ce0a049 into main Feb 20, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/avoid-shared-subject-keyframe branch February 20, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ