Skip to content

Refactor the CI matrix #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 7, 2025
Merged

Refactor the CI matrix #555

merged 19 commits into from
May 7, 2025

Conversation

cryos
Copy link
Collaborator

@cryos cryos commented Apr 10, 2025 •
edited
Loading

Description

Refactor the CI matrix - closes #576.

Refactor the way the CI matrix is composed to be layered, add proxy cache to improve Python package download times, offer a concept of pull request and nightly matrix for the tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Apr 10, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cryos cryos marked this pull request as draft April 10, 2025 20:29
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Apr 10, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cryos
Copy link
Collaborator Author

cryos commented Apr 10, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented Apr 10, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented Apr 10, 2025

/ok to test

@cryos cryos added the CI/CD CI/CD infrastructure label Apr 10, 2025
@cryos
Copy link
Collaborator Author

cryos commented Apr 10, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented Apr 11, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented Apr 11, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented Apr 11, 2025

/ok to test a8238f2

@cryos
Copy link
Collaborator Author

cryos commented Apr 11, 2025

/ok to test 3097f67

@cryos
Copy link
Collaborator Author

cryos commented Apr 11, 2025

/ok to test 3fff795

@leofang leofang self-requested a review April 17, 2025 05:48
@leofang leofang added the P1 Medium priority - Should do label Apr 17, 2025
leofang
leofang reviewed Apr 17, 2025
View reviewed changes
@cryos
Copy link
Collaborator Author

cryos commented Apr 17, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented Apr 17, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented Apr 17, 2025

/ok to test

@cryos cryos requested review from leofang and kkraus14 May 5, 2025 17:42
@leofang
Copy link
Member

leofang commented May 5, 2025

(btw I'll be able to review/merge this PR after we push out cuda.bindings 12.9.0 today.)

@cryos
12.0.1 won't with with CUDA 11.x drivers
ab1a327 
Also fix the conditional install of git for windows based on local CTK.
@cryos
Copy link
Collaborator Author

cryos commented May 5, 2025

/ok to test

@cryos
Remove build-and-test.yml
2e811f3 
This is replaced by `ci.yml`.
@cryos
Copy link
Collaborator Author

cryos commented May 6, 2025

/ok to test

kkraus14
kkraus14 reviewed May 6, 2025
View reviewed changes
@cryos cryos requested a review from kkraus14 May 6, 2025 14:38
leofang
leofang previously approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please hold off merging until we push out 12.9.0 wheels later today 🤞

@cryos
Copy link
Collaborator Author

cryos commented May 6, 2025

/ok to test

kkraus14
kkraus14 previously approved these changes May 6, 2025
View reviewed changes
@cryos
Make cuda-verion required, add missing copright/license
c5eb72c 
Also pin actions to SHAs (skip ilammy/msvc-dev-cmd for now awaiting
update to the allow list).
@cryos cryos dismissed stale reviews from kkraus14 and leofang via 4234124 May 6, 2025 20:41
@cryos
Copy link
Collaborator Author

cryos commented May 6, 2025

/ok to test

@cryos
Copy link
Collaborator Author

cryos commented May 6, 2025

/ok to test

@cryos cryos requested a review from leofang May 6, 2025 22:40
@leofang
Copy link
Member

leofang commented May 7, 2025

FYI, we've done GitHub & PyPI releases, so feel free to merge anytime!

@leofang leofang added the enhancement Any code-related improvements label May 7, 2025
@cryos cryos merged commit b1085ca into NVIDIA:main May 7, 2025
54 checks passed
@leofang
Copy link
Member

leofang commented May 7, 2025

Many thanks, Marcus! Nice refactoring!!

@cryos
Copy link
Collaborator Author

cryos commented May 7, 2025

Many thanks, Marcus! Nice refactoring!!

Thanks Leo - more to come but it is good to land this and verify everything looks good.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

@cryos cryos mentioned this pull request May 7, 2025
Merged
3 tasks
@leofang leofang added this to the cuda.core beta 4 milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

@kkraus14 kkraus14 kkraus14 left review comments

Assignees

@cryos cryos

Labels
CI/CD CI/CD infrastructure enhancement Any code-related improvements P1 Medium priority - Should do
Projects
None yet
Milestone
cuda.core beta 4
Development

Successfully merging this pull request may close these issues.

CI: Refactor the CI matrix
3 participants
@cryos @leofang @kkraus14