-
Notifications
You must be signed in to change notification settings - Fork 171
CI: Reference workflow file name for old branch #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Switch to use the workflow file name as the name is getting missed in the merged code in main. Verified the behavior locally too.
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
This comment has been minimized.
This comment has been minimized.
@leofang see failures after merge where the workflow name is not found. In general I have used workflow file names and they have been reliable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Marcus! Yes, I noticed the main failed too. So instead of backporting the CI name change, we just fix it by referring to the workflow filename. (I did not know this works!) The only catch is that when the current main branch becomes the backport branch in the future, we'll need to change it to ci.yaml
.
One question: Why didn't we observe this failure in #555? |
Not clear and that is frustrating! I guess we hit a corner case, I will merge this and see if it is more reliable. |
Yes, and I think I will have factored out some of this common code into helper scripts better by that point too. |
|
Description
Switch to use the workflow file name as the name is getting missed in the merged code in main. Verified the behavior locally too. This is a follow up from #555 addressing an issue seen after merging.
Checklist