-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Added PhpOffice\Common as requirement #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That will help you with the support of PHP7 (String => Text). |
Looks like we are solving the same issue. I like your naming better. Whatever works for php 7.0. Ill remove my CommonString if this branch gets merged but keep travis settings. |
@RomanSyroeshko please review this pull request |
Will there be a bugfix release for this one? I really need this, but 0.13.* isn't released yet... |
how soon will this be released? |
@RomanSyroeshko it's been half year and still the problem has not been solved, come on man! |
It looks like this has been resolved in the develop branch.
|
This is included in https://github.com/PHPOffice/PHPWord/releases/tag/v0.13.0 |
How does it work? I mean for upgrading from previous versions? I just keep getting
|
Class PhpOffice\PhpWord\Shared\String was renamed for compatibility with php7 |
v0.13.0 is ever released and fixes bugs : https://github.com/PHPOffice/PHPWord/releases/tag/v0.13.0 |
@RomanSyroeshko : I wait for your validation :)