PHP7 Update - Renamed String class to SharedString #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This build is failing because of mpdf. mpdf is still using the old constructor style that is not suitable for PHP7. A fix was pulled into mpdf's development branch ( mpdf/mpdf#68 ) but has not yet been tagged and thus is not pulled in via composer package. |
|
I have updated composer.json to pull dev-development for mpdf, which has merged the constructor fix for PHP7. In the future, once the fix is pulled into a release tag, we need to change the composer.json to a stable version. Hopefully, this won't take too long. |
|
Partially resolved in scope of #658. |
|
what does this need to be merged? |
|
Some thoughts. mPDF 6.1 requires PHP 5.4+ while PHPWord - PHP 5.3.3+. So, first of all #355 should be resolved. |
ghost
closed this
ghost
reopened this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP7 now reserves the class name String. PHPWord utilizes String as a class name, thus PHPWord presently does not work with PHP7. This PR renames the class to SharedString and updates it usage through the library and in the tests.