895 Update temp directory function in all tests and examples

[Nic-Ma]

Fixes #895 .

Description

This PR updated the tempfile usage in all the tests and examples according to @ericspod 's suggestion.
I didn't change the usage in integration tests because it's used as a class member and didn't change the usage in all the notebooks because it's hard to use "with ... as ... :" in notebooks.

And I also fixed several missing "delete" issue for temp directory in tests, thanks for @ericspod 's suggestion, tempfile.TemporaryDirectory is really better to avoid errors.

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

/black

[Nic-Ma]

/black

[Nic-Ma]

/black

[ericspod]

I'm good with this, does anyone have any other input @wyli @atbenmurray ?

[wyli]

this was changed back and forth @Nic-Ma and now I can't remember why we did those, e.g.
#446
10203f3

[Nic-Ma]

Hi @wyli ,

The previous 2 PRs were:

1. At the beginning, only few tests used tempdir and others used current dir, so the first PR is to use tempdir for all.
2. The second PR is because I thought with tempfile.TemporaryDirectory() as tempdir: is using system /tmp/ folder, so I used tempfile. mkdtemp() to replace them, which is not correct.

Now thanks for @ericspod 's suggestion, with tempfile.TemporaryDirectory() as tempdir: actually creates a temp dir and good for our cases, I think it's much more clear now.

Thanks.

[wyli]

ok, sounds good, I only have a minor comment about the style

[wyli]

I think we should avoid this large block of indentation by adding the context from outside of main, something like:

 if __name__ == "__main__":
    with tempfile.TemporaryDirectory() as tempdir:
        main(tempdir)

[Nic-Ma]

good point, I will change the examples soon.
Thanks.